Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

progress - remove options #92446

Merged
merged 1 commit into from Mar 16, 2020
Merged

progress - remove options #92446

merged 1 commit into from Mar 16, 2020

Conversation

bpasero
Copy link
Member

@bpasero bpasero commented Mar 11, 2020

As I was thinking earlier, we should not need the options. The indicator is fit to replay progress even if a scope is not active and comes back so it should be fine.

I tested this with the code from #92445 when switching between 2 viewlets.

@bpasero bpasero added this to the March 2020 milestone Mar 11, 2020
@bpasero bpasero requested a review from eamodio March 11, 2020 08:20
@bpasero bpasero self-assigned this Mar 11, 2020
@eamodio eamodio merged commit 379e0e3 into master Mar 16, 2020
@eamodio eamodio deleted the ben/progress-options-removal branch March 16, 2020 19:56
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shivaylamba shivaylamba shivaylamba approved these changes

@eamodio eamodio Awaiting requested review from eamodio

Assignees

@bpasero bpasero

Labels
None yet
Projects
None yet
Milestone
March 2020
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bpasero @shivaylamba @eamodio